Align compression levels with Envoy #97
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gzip compression, our default, uses Python's default of level 9 which is for long term storage like OS packages and not good for network servers.
I wanted to align with some standard for defaults, and went with Envoy where brotli=3, gzip=6, zstd=3
For reference, connect-go uses the defaults for the Go libraries for all compressions (zstd / brotli are within the conformance runner), which are level=6 for gzip and brotli, and default (level 3) for zstd.
As gzip is used by default, this is probably closer to a bug than performance enhancement
#96