Fix-Restore info icon visibility in peer review screen#6802
Open
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Open
Fix-Restore info icon visibility in peer review screen#6802Roniscend wants to merge 1 commit intocommons-app:mainfrom
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Conversation
Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Peer Review screen’s landscape layout and click handling so the “info” affordance and “Skip this image” interaction remain visible/usable after rotation (fixes #6787).
Changes:
- Refactors
layout-land/activity_review.xmlto place a dedicated info icon view next to the “Skip this image” button and reorders constraints/layout structure. - Adds an
android:idto the included toolbar in the landscape layout for consistent view binding. - Switches the skip-info interaction in
ReviewActivityfrom a touch listener to a click listener.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| app/src/main/res/layout-land/activity_review.xml | Reworks the landscape peer review layout to keep the skip + info UI reliably visible and constrained. |
| app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.kt | Simplifies skip-info handling to use a click listener. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Generated APK variants! |
Contributor
Author
|
@nicolas-raoul can you review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Corrected UI logic to ensure info icon is consistently visible in peer review screen.
Fixes #6787
Tested 6.4.0-debug on Pixel 9(Android 16)
Screenshots (for UI changes only)
b.mp4