propagate click event to popover item activation callback#2703
Open
mauritskorse wants to merge 2 commits intocodex-team:nextfrom
Open
propagate click event to popover item activation callback#2703mauritskorse wants to merge 2 commits intocodex-team:nextfrom
mauritskorse wants to merge 2 commits intocodex-team:nextfrom
Conversation
Contributor
|
Hi! Can you please provide the use case for which you need to have an |
Contributor
|
Also, please add a test and update changelog |
Author
Use case is to get the xy position of the menu item such that I can position a modal next to the popover menu item when clicked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For creating modals that can attach to the popover menu, it is useful to have the event data being propagated to the onActivate() callback. The interface already had the event implemented:
editor.js/src/components/utils/popover/components/popover-item/popover-item.types.ts
Line 91 in 238c909
But the methods in after the event listener did not pass the event data on yet.