Merged
Conversation
Replace the jQuery minicolors plugin with a custom per-instance ES6 ColorPicker class. This eliminates the jQuery dependency for color picking and gives us full control over the behavior. Better keyboard and pointer interaction. Better support for colors with alpha component. REDMINE-21228
Avoid full configuration editor refresh when only the preview content (e.g. exampleNode text) changes. Only refresh when the node type changes since that affects which typography variants are available. REDMINE-21228
No longer needed since the custom ColorPicker replaced it. Also fix color picker closing when clicking the gradient area a second time by preventing default on pointerdown. REDMINE-21228
Let users configure remaining waveform and cursor colors in addition to the existing progress color. Color pickers show swatches of colors already used across content elements. Default colors adapt to the section's invert setting. REDMINE-21228 Waveform
Let users toggle to a dark play button on waveform player controls. The default white button gets a subtle drop shadow for better visibility. The inverted variant removes the shadow. REDMINE-21228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21228