Skip to content

feat(bootstrap-gcp): Add public keys of specified github team#230

Open
NautiluX wants to merge 6 commits intomainfrom
github-pubkeys
Open

feat(bootstrap-gcp): Add public keys of specified github team#230
NautiluX wants to merge 6 commits intomainfrom
github-pubkeys

Conversation

@NautiluX
Copy link
Member

@NautiluX NautiluX commented Mar 11, 2026

Adds the ability to specify a GitHub team and org. All team member's public keys will be added to created VMs.

Also, updated some variable names for consistent naming (Github vs GitHub)

ClickUp: https://app.clickup.com/t/869cfj7ku

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support to bootstrap-gcp for fetching SSH public keys from members of a specified GitHub org/team and injecting those keys into the created GCE VMs’ ssh-keys instance metadata.

Changes:

  • Introduces a small GitHub client abstraction (real + mock) for listing team members and their SSH keys.
  • Extends GCP bootstrap environment/config/CLI flags to accept github-team-org + github-team-slug and wires the GitHub client into the bootstrapper.
  • Updates EnsureComputeInstances and tests to include team keys and avoid repeated SSH key file reads.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
internal/bootstrap/gcp/mocks.go Adds a mock GitHub client used by bootstrapper tests.
internal/bootstrap/gcp/github_client.go Adds real GitHub client wrapper + interface used by the bootstrapper.
internal/bootstrap/gcp/gcp_test.go Updates bootstrapper construction and adds/adjusts tests for GitHub team validation and SSH metadata behavior.
internal/bootstrap/gcp/gcp.go Adds env fields + validation, injects GitHub client, fetches team keys, and updates SSH metadata generation.
cli/cmd/bootstrap_gcp.go Adds CLI flags for GitHub team org/slug and wires up the real GitHub client.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

NautiluX and others added 4 commits March 13, 2026 12:59
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@NautiluX NautiluX requested a review from joka134 March 13, 2026 12:34
@NautiluX NautiluX force-pushed the github-pubkeys branch 2 times, most recently from a3902e4 to 1934d79 Compare March 13, 2026 12:36
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants