feat: add support for Spot VMs and validation for provisioning options#213
feat: add support for Spot VMs and validation for provisioning options#213OliverTrautvetter wants to merge 18 commits intomainfrom
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds Spot VM support to the GCP bootstrap flow, including input validation and behavior changes to reuse/restart existing instances.
Changes:
- Add
--spotCLI flag + docs and validation to prevent combining Spot and Preemptible. - Extend instance provisioning to support Spot scheduling with capacity-exhaustion fallback to standard VMs.
- Reuse existing instances (including starting stopped instances) and update mocks/tests accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/bootstrap/gcp/gcp.go | Implements Spot scheduling + fallback, adds provisioning validation, and starts/reuses existing instances. |
| internal/bootstrap/gcp/gcp_client.go | Extends GCPClientManager with StartInstance and implements it in GCPClient. |
| internal/bootstrap/gcp/mocks.go | Updates generated mock to include StartInstance. |
| internal/bootstrap/gcp/gcp_test.go | Updates tests for new instance lookup behavior; adds coverage for spot/fallback/start scenarios and validation. |
| cli/cmd/bootstrap_gcp.go | Wires new --spot flag into CLI. |
| docs/oms_beta_bootstrap-gcp.md | Documents the new --spot flag in command help output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…re-cloud/oms into bootstrap_with_spot_vms
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
…re-cloud/oms into bootstrap_with_spot_vms
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
…re-cloud/oms into bootstrap_with_spot_vms
Add the ability to bootstrap private-cloud infrastructure for quick testing on spot instances, so that the cost is minimized
Clickup