Closed
Conversation
- Use RepoRoot-relative paths instead of joining with current directory - Introduce clientFactory pattern for lazy client creation in generate docker - Format OpenAPI client code and fix float formatting
Split the monolithic integration_test.go into individual files, each with a Ginkgo label for selective execution via matrix CI: curl_test.go (curl), error_handling_test.go (error-handling), git_test.go (git), list_test.go (list), log_test.go (log), monitor_test.go (local), pipeline_test.go (pipeline), version_help_test.go (local), wakeup_test.go (wakeup), workspace_test.go (workspace) Extract shared constants and helpers into int/util/.
- Split CI into build, test (parallel per-label matrix), and cleanup jobs - Define label list once; derive matrix and unlabeled filter dynamically - Add unique run-name with github.run_id to avoid parallel conflicts - Fetch latest hadolint and kubeconform versions at install time - Add per-label Makefile targets (test-int-workspace, test-int-list, etc.)
Add comprehensive tests for generate docker, kubernetes, and images commands. Tests validate generated Dockerfiles, shell scripts, and K8s manifests (Deployments, Services, Ingress) by unmarshalling into typed structs and running linters (hadolint, shellcheck, kubeconform) when available. Add int/util/linters.go with a single runLinter function that handles tool discovery, skip-on-missing behavior, and failure reporting.
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO