Skip to content

feat: add integration test for kubernetes#198

Merged
OliverTrautvetter merged 34 commits intomainfrom
kubernetes_integration_tests
Mar 13, 2026
Merged

feat: add integration test for kubernetes#198
OliverTrautvetter merged 34 commits intomainfrom
kubernetes_integration_tests

Conversation

@OliverTrautvetter
Copy link
Member

@OliverTrautvetter OliverTrautvetter commented Mar 2, 2026

Add automated tests for the kubernetes export features.

Split the large integration test file into smaller files and add labels to identify each test

Clickup

@OliverTrautvetter OliverTrautvetter changed the title feat: add integration test for kubernetes first attempt feat: add integration test for kubernetes Mar 2, 2026
@OliverTrautvetter OliverTrautvetter marked this pull request as ready for review March 5, 2026 09:32
@OliverTrautvetter OliverTrautvetter requested a review from a team as a code owner March 5, 2026 09:32
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Copy link
Member

@joka134 joka134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the scenarios, but I think we should test if the generated files are valid files as far as we possibly can. So integrating linters for yaml, bash, python or actual validators for docker or k8s would make sense here

Copy link
Member

@joka134 joka134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a PR split and do the creation and deletion steps during the integration test split in the same commit. Currently every line of all tests is new 😆

Copy link
Member

@joka134 joka134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@OliverTrautvetter OliverTrautvetter merged commit c6360e2 into main Mar 13, 2026
12 of 16 checks passed
@OliverTrautvetter OliverTrautvetter deleted the kubernetes_integration_tests branch March 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants