Open
Conversation
SafetyInObscurity
requested changes
Feb 14, 2026
Comment on lines
+13
to
+22
| function getGameCoverUrl( | ||
| game_cover_thumbnail: string | null | undefined, | ||
| ): string { | ||
| if (!game_cover_thumbnail) return "/game_dev_club_logo.svg"; | ||
| if (game_cover_thumbnail.startsWith("http")) return game_cover_thumbnail; | ||
| // Use environment variable for Django backend base URL | ||
| const apiBaseUrl = | ||
| process.env.NEXT_PUBLIC_API_BASE_URL || "http://localhost:8000"; | ||
| return `${apiBaseUrl}${game_cover_thumbnail}`; | ||
| } |
Collaborator
There was a problem hiding this comment.
This function is unnecessary. We can just use the URL sent by the backend, and not display an image if necessary.
We definitely shouldn't be hard coding URLs like "http://localhost:8000".
| className="group-hover:brightness-75 group-hover:duration-200" | ||
| /> | ||
| <Link | ||
| className="mt-[-165px] hidden place-self-center rounded-md bg-accent p-3 font-firaCode text-light_1 drop-shadow-md hover:underline group-hover:flex group-hover:blur-0 group-hover:duration-200" |
Collaborator
There was a problem hiding this comment.
Please don't use pixel units for css. The standard tailwind units are much more consistent and responsive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
Related issue