Open
Conversation
sync with module3
sync module4 - conditional variables
ziobron
requested changes
Feb 19, 2021
Contributor
ziobron
left a comment
ziobron
left a comment
There was a problem hiding this comment.
Doesn't work correctly for numOfReps = 1
ziobron@MBP:~/workspace/reveal.js/md.multithreading/module4$ ./plewa 1 100
Ping
Ping is finishing game. Num reps has reached 1
Game finished.
It was possible for me to end it with ping without a pong
Pong
Ping
Stop is finishing game - timeout.
Pong
Ping
on apple clang there is a data race - https://pastebin.pl/view/f5924827
but it's probably because of some differencies in stdlib. adding locks in ifs helps.
| // TODO: wait to be used here + printing, reps incrementation, chainging turn to ping | ||
| this_thread::sleep_for(500ms); | ||
| opponentsTurn_.wait(l, [&] {return !isPingTurn_.load(); }); | ||
| cout << "Pong" << endl; |
Contributor
There was a problem hiding this comment.
consecutive number is not printed
added 3 commits
February 22, 2021 09:48
…multithreading into module4_homework_ping_pong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.