This repository was archived by the owner on May 9, 2020. It is now read-only.
Open
Conversation
kamilbednarz
force-pushed
the
feature/encrypted-data-bags
branch
from
f6a6773 to
105b22e
Compare
Owner
|
"maintain" is a relative term. Given that encrypted data bags are very bad and no one should use them, I'm not really chomping at the bit to spend time supporting them, but I'll look when I get a chance. |
Author
|
Thanks, LMK if I can help somehow. |
code-haven
reviewed
Jan 2, 2019
| if os.path.exists(self.secret_file): | ||
| self.encryption_key = open(self.secret_file).read().strip() | ||
| if secret_key is not None: | ||
| if encryption_key is not None: |
There was a problem hiding this comment.
This should check self.encryption_key instead - as encryption_key is not defined
|
@kamilbednarz Thanks for this. We are using the changes in this PR in a local fork and it works just fine! |
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @coderanger ,
It's another attempt to get the Encrypted Data bag items support merged in. 💯
I updated my ancient (4-year old) branch with the latest upstream master code, so should be easy to merge.
Also, thanks to @fpedrini we also have a few additions here:
FYI: It's an enhanced clone of #27
Let me know what do you think and if you still maintain this repo.
All the best,
-Kamil