C2LC-448: Added ctrl+shift key bindings.#240
Open
the-t-in-rtf wants to merge 9 commits intocodelearncreate:develop-1.2from
Open
C2LC-448: Added ctrl+shift key bindings.#240the-t-in-rtf wants to merge 9 commits intocodelearncreate:develop-1.2from
the-t-in-rtf wants to merge 9 commits intocodelearncreate:develop-1.2from
Conversation
Contributor
|
The changes look good, and works well on both Windows and MacOS. |
Contributor
Author
|
I merged with develop 1.2 and fixed a linting error introduced by the merge, this one is clean again. |
Contributor
Author
|
The "escape" tests for the keyboard handler were trying to toggle the audio settings, which didn't work following the audio settings refactor. I changed that to use a different setting, as we were just testing "escape" functionality there. I will also review to make sure we didn't lose any key bindings during the merge. |
Contributor
Author
|
Seems fine, although we only have a shortcut to toggle announcements at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See C2LC-448 for details.