C2LC-431: Add Keyboard shortcut for expand and collapse add nodes#230
C2LC-431: Add Keyboard shortcut for expand and collapse add nodes#230chosww wants to merge 4 commits intocodelearncreate:develop-1.0from
Conversation
| keyDef: { code: "KeyS", key: "s", altKey: true}, | ||
| actionName: "stopProgram" | ||
| }, | ||
| expandAddNode: { |
There was a problem hiding this comment.
For now this is fine, but as we pick up more bindings (like the help key) that are the same between all schemes, we should probably make and reuse a "common" binding definition, like we do with extended keyboard sequences. I think a TODO here would be a good idea for now.
There was a problem hiding this comment.
Current keyboard shortcut combinations are likely to change, so I think it makes sense to wait until we talk about rework of the keyboard shortcut combinations.
|
I left a small comment on the code changes, but was not able to perform QA in the time I had, as the preview deployment failed. |
|
I performed QA on this with a local copy of the branch. It works as expected on all browsers, and I confirmed that the change is equivalent to hitting the toggle, i.e.:
|
2 participants
See C2LC-431 for details.