C2LC-430: Add keyboard shortcut for the share button#229
C2LC-430: Add keyboard shortcut for the share button#229chosww wants to merge 2 commits intocodelearncreate:develop-0.9from
Conversation
|
|
||
| handleShareButtonShortcut = () => { | ||
| const currentUrl = document.location.href; | ||
| return navigator.clipboard.writeText(currentUrl); |
There was a problem hiding this comment.
Does this mean there's no onscreen or announced feedback? It seems like there should be.
There was a problem hiding this comment.
Didn't we say that the shortcut will just copy the url to the clipboard without the feedback message? And communicate more clearly with the name used in grid key for the switches, like "copy the current url"?
There was a problem hiding this comment.
I still like letting people know that they've actually succeeded in hitting the key combination. It doesn't have to be visual feedback, though. Maybe this is a good use case for a preview announcement?
There was a problem hiding this comment.
I agree that a preview(maybe feedback you mean?) announcement can make this clear.
There was a problem hiding this comment.
Yes, I'm still getting them straight in my head, I guess in this case I did mean feedback.
|
I left a comment here on the code but wasn't able to test the work in the time I have, as the preview deployment failed. |
|
I performed QA against a copy of the branch checked out locally and confirmed that it works with FF, Chrome, and Safari. I tested both keyboard input schemes. |
2 participants
See C2LC-430 for details.