Merged
Conversation
…sdom for jest 29 to tackle import errors, committing as is to test in CI
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Well, at least the tests are passing and it looks like an unrelated yargs version upgrade is causing the type check issues. |
…nstallation conflict, yarn fix
Mephistic
requested review from
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Jest to 29 (and upgrading related packages as well) - this + the customEnvironmentResolution changes in the config files should resolve the issues we've been seeing with import failures around testing, so will hopefully help the V2 Firebase function upgrades @AstorDG is working on.
There's a bunch of separate stuff we should probably do to improve the testing flow (among other things, take advantage of
firebase-functions-testso we can have better unit/integration tests of firebase functions, which would massively build confidence in the V2 upgrade, getting jest up to 30, and getting better wrappers around the hearing scrapers), but that's a problem for another day.