refactor: make openNfcSettings nullable on PlatformActions#235
Merged
codebutler merged 1 commit intomasterfrom Feb 17, 2026
Merged
refactor: make openNfcSettings nullable on PlatformActions#235codebutler merged 1 commit intomasterfrom
codebutler merged 1 commit intomasterfrom
Conversation
Platforms without OS NFC settings (web, desktop) now return null instead of providing a no-op. The UI hides the "NFC Settings" banner and guards the scan FAB accordingly, so users on those platforms never see a dead button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openNfcSettingsfrom a required function to a nullable property onPlatformActionsnull(default)null, so platforms without OS NFC settings never show a dead buttonTest plan
🤖 Generated with Claude Code