feat: split /events into upcoming and past pages#2508
Open
mroderick wants to merge 1 commit intocodebar:masterfrom
Open
feat: split /events into upcoming and past pages#2508mroderick wants to merge 1 commit intocodebar:masterfrom
mroderick wants to merge 1 commit intocodebar:masterfrom
Conversation
- /events now redirects to /events/upcoming - /events/upcoming shows upcoming events (paginated at 20) - /events/past shows past events (paginated at 20, sorted descending) - Updated navigation with Upcoming Events and Past Events items - Updated footer and dashboard links to point to upcoming_events_path - Renamed index.html.haml to upcoming.html.haml - Updated tests for new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this PR that when a user wants to know about upcoming events, they not very likely to be interested in past events, yet the
/eventspage would still spend a lot of effort (and user time) on fetching and rendering past events.The PR splits the
/eventsroute into two routes/events/upcomingand/events/past, and adds pagination to each of these.Summary
/eventsnow redirects to/events/upcoming/events/upcomingshows upcoming events (paginated at 20)/events/pastshows past events (paginated at 20, sorted descending by date)Test Plan
Open questions