fix(plugin-eslint): parse rule names containing slashes correctly#895
Merged
matejchalk merged 1 commit intomainfrom Dec 17, 2024
Merged
fix(plugin-eslint): parse rule names containing slashes correctly#895matejchalk merged 1 commit intomainfrom
matejchalk merged 1 commit intomainfrom
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit f570c58 with source commit 284f755. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score🗃️ Groups
15 other groups are unchanged. 🛡️ Audits
567 other audits are unchanged. |
vmasek
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rules from
eslint-plugin-nweren't being discovered correctly, was being logged as warning:This is because for rule IDs like
n/prefer-promises/fsthe parser incorrectly identified which part was the plugin name.Now that the parsing was adjusted, the warnings are gone.