Fix auto-migration to next phase

[Didayolo]

Description

Previously, the phase migration returned N/a scores on the leaderboard. The problem was that the submission was actually run on a task from the previous phase.

This simple change fixes:

• Scores displayed on leaderboard
• Submission migrated run on the right task(s)

Issues this PR resolves

• Point 2. c) of Wrong leaderboard ordering and N/a scores discussion #1540

A checklist for hand testing

• Make a leaderboard submission
• Set up the next phase to change soon and enable "auto-migrate to this phase"
• Wait and check that the submission run and is displayed well on leaderboard

If the auto-migration is not triggered, you can enter inside Django container, shell_plus, and run:

from competitions.tasks import manual_migration
manual_migration(<FIRST_PHASE_ID>)

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• CircleCi tests are passing
• Ready to merge

[Didayolo]

Hi @ObadaS,

I put you as a reviewer if it's OK for you, because:

• It is a fairly simple change
• It is needed by Guillaume and Théo soon

Thank you!

[ObadaS]

Hello @Didayolo, I can't manage to make migrations work. The migration is launched from the site worker without problems but nothing appears on the leaderboard or the submissions tab.
I am trying it on a multitask competition, should I only try it on a normal one task only competition ?

[Didayolo]

Hello @Didayolo, I can't manage to make migrations work. The migration is launched from the site worker without problems but nothing appears on the leaderboard or the submissions tab. I am trying it on a multitask competition, should I only try it on a normal one task only competition ?

Are your submissions on the leaderboard?

If so, maybe the multi-task is the problem. When I tried on production, and locally after my change, I don't think I tried with a multi-task competition.

[ObadaS]

Yes, I have 2 submissions. One on the leaderboard, and one not on the leaderboard.
I will try on a normal competition and report back

[Didayolo]

Yes, I have 2 submissions. One on the leaderboard, and one not on the leaderboard. I will try on a normal competition and report back

OK. I will test a multi-task on production to see if their is an already existing problem with that.

---

Update: with multi-task on production, the submission did not started on next phase.

[Didayolo]

To tackle next:

• Auto-migration timing #2246
• Auto-migration not working for multi-task #2247