Open
Conversation
IdirLISN
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Generation of a random secret key for django instance when building the app.
Write the value on .env.
each docker compose up -d, entrypoint.sh will read the variable in .env, if it doesn't exist it will generate one random secret key.
If a user want to deploy his own codabench instance, it will be secured with a unique secret key.
Enables django to use a private secret key for each new instance of it.
Issues this PR resolves
Secret key was clear and was the same for all instances. It means all codabench instances can authenticate to each other.
A checklist for hand testing
Checklist