Skip to content

fix: start API server only after cache sync to prevent startup race #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblos merged 2 commits into from
May 12, 2026
Merged

fix: start API server only after cache sync to prevent startup race #836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281bdec
fix: start API server only after cache sync to prevent startup race
mblos May 11, 2026
3d0526c
fix
mblos May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,11 +907,17 @@ func main() {
}
}

signalCtx := ctrl.SetupSignalHandler()

errchan := make(chan error)
go func() {
if !mgr.GetCache().WaitForCacheSync(signalCtx) {
setupLog.Error(nil, "cache sync failed, exiting before starting api server")
os.Exit(1)
}
errchan <- func() error {
setupLog.Info("starting api server", "address", ":8080")
return httpext.ListenAndServeContext(ctx, ":8080", mux)
return httpext.ListenAndServeContext(signalCtx, ":8080", mux)
}()
}()
go func() {
Expand All @@ -922,7 +928,7 @@ func main() {
}()

setupLog.Info("starting manager")
if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
if err := mgr.Start(signalCtx); err != nil {
setupLog.Error(err, "problem running manager")
os.Exit(1)
}
Expand Down