Skip to content

Refactor /traits API to single-ConfigMap model with Syncer interface #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippMatthes merged 2 commits into from
Apr 29, 2026
Merged

Refactor /traits API to single-ConfigMap model with Syncer interface #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2273619
Refactor /traits API to single-ConfigMap model with Syncer interface
PhilippMatthes Apr 29, 2026
891e77d
Address review feedback: body copy, sync gating, lock serialization
PhilippMatthes Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions helm/bundles/cortex-placement-shim/templates/configmap-traits.yaml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions helm/bundles/cortex-placement-shim/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ cortex-shim:
status: "CURRENT"
traits:
configMapName: "cortex-placement-shim-traits"
# Static traits included in every Helm install/upgrade. The shim
# merges them with dynamic CUSTOM_* traits at request time.
static: []
auth:
tokenCacheTTL: "5m"
policies:
Expand Down
Loading
Loading