Skip to content

Fix status patch no-op when spec changes during allocation reconciliation #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblos merged 1 commit into from
Apr 27, 2026
Merged

Fix status patch no-op when spec changes during allocation reconciliation #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/scheduling/reservations/commitments/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,12 @@ func (r *CommitmentReservationController) reconcileAllocations(ctx context.Conte
}
return nil, fmt.Errorf("failed to re-fetch reservation: %w", err)
}
// Capture the re-fetched state as the patch base BEFORE re-applying
// the status update. Otherwise MergeFrom(old) would see no diff
// and the status patch would be a no-op.
old = res.DeepCopy()
// Re-apply the status update that was overwritten by the re-fetch.
res.Status.CommittedResourceReservation.Allocations = newStatusAllocations
old = res.DeepCopy()
}

// Patch Status
Expand Down
Loading