RN47.0 has removed createJSModules method#86
Open
prscX wants to merge 1 commit intocnjon:masterfrom
prscX:master
Open
RN47.0 has removed createJSModules method#86prscX wants to merge 1 commit intocnjon:masterfrom prscX:master
createJSModules method#86prscX wants to merge 1 commit intocnjon:masterfrom
prscX:master
Conversation
This was referenced Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
RN47.0 has removed createJSModule method from ReactPackage.java. In order to make it work on Android with RN47.0, I have removed @overide annotation from PDFView.java class.
Can you please merge and release so that we can seamlessly use this library on RN47.0 and above
Please let me know in case any changes are required
Thanks,
Pranav