Fix tests to support latest Docker version #92
Merged
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the testCreateConnectDisconnectAndRemoveNetwork test to support both newer Docker Engine API versions (released around mid-2025) and older versions. The newer Docker versions emit fewer network events for containers that aren't started.
Changes:
- Modified event assertion logic to handle both 2-event (newer Docker) and 3-event (older Docker) scenarios
- Added array extraction logic for 'Action' field to support version comparison
- Maintains backward compatibility with older Docker Engine versions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes the tests to support latest Docker version. Exact Docker Engine API version is unknown, but released some time around mid 2025, the changelogs weren't exactly helpful here. In either case, this fixes test compatibility with newer versions while also keeping support for earlier engine versions similar to how this was previously done in #80.
Builds on top of #80