Skip to content

Add phase-configs support to Hook model for target-app resolution #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stiv03 wants to merge 3 commits into from
+0 −2
Closed

Add phase-configs support to Hook model for target-app resolution #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d73b6
Add phase-configs support to Hook model for target-app resolution
stiv03 Apr 2, 2026
df82bae
Fix JSON serialization for tests
stiv03 Apr 6, 2026
7caa32c
Revert phase-configs: new param
stiv03 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...apps-mta/src/main/java/org/cloudfoundry/multiapps/mta/parsers/v3/ExtensionHookParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import java.util.List;
import java.util.Map;
import java.util.Set;

import org.cloudfoundry.multiapps.common.ParsingException;
import org.cloudfoundry.multiapps.mta.model.ExtensionHook;
import org.cloudfoundry.multiapps.mta.model.ExtensionRequiredDependency;
Expand Down
1 change: 0 additions & 1 deletion multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/parsers/v3/HookParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import java.util.List;
import java.util.Map;
import java.util.Set;

import org.cloudfoundry.multiapps.common.ParsingException;
Copy link
Copy Markdown
Contributor

@IvanBorislavovDimitrov IvanBorislavovDimitrov Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MINOR] Clean Code -- Unnecessary blank line removal

The blank line between java.util.Set and org.cloudfoundry.multiapps imports was removed. This is a minor formatting change that is unrelated to the feature and creates noise in the diff. Most Java style guides (including the one observed in this codebase) separate java.* and org.* import groups with a blank line.

import org.cloudfoundry.multiapps.mta.model.Hook;
import org.cloudfoundry.multiapps.mta.model.RequiredDependency;
Expand Down
Loading