Fix default_order_by_id for association loading#5089
Draft
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Draft
Fix default_order_by_id for association loading#5089philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
philippthun
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
e6b21da to
6e670f0
Compare
The extension hooks into Dataset#all/each/first to inject ORDER BY id, but Sequel's PlaceholderLiteralizer bypasses these methods entirely. It pre-compiles SQL via Dataset#sql and calls with_sql_all directly, so associations loaded through this optimized path had no deterministic ordering. Override placeholder_literalizer_loader to inject the ordering into the dataset before it gets compiled into a reusable SQL template.
philippthun
force-pushed
the
fix-default-order-by-id-association-loading
branch
from
6e670f0 to
e770afa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension hooks into
Dataset#all/each/firstto injectORDER BY id, but Sequel'sPlaceholderLiteralizerbypasses these methods entirely. It pre-compiles SQL viaDataset#sqland callswith_sql_alldirectly, so associations loaded through this optimized path had no deterministic ordering.Override
placeholder_literalizer_loaderto inject the ordering into the dataset before it gets compiled into a reusable SQL template.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests