-
Notifications
You must be signed in to change notification settings - Fork 624
Removes deprecated built-in Python package support. #6114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5834,11 +5834,10 @@ kj::Promise<void> Server::preloadPython( | |
| // Preload Python packages. | ||
| KJ_IF_SOME(modulesSource, workerDef.source.variant.tryGet<Worker::Script::ModulesSource>()) { | ||
| if (modulesSource.isPython) { | ||
| auto pythonRequirements = getPythonRequirements(modulesSource); | ||
|
|
||
| // Store the packages in the package manager that is stored in the pythonConfig | ||
| co_await server::fetchPyodidePackages(pythonConfig, pythonConfig.pyodidePackageManager, | ||
| pythonRequirements, release, network, timer); | ||
| co_await server::fetchPyodidePackages( | ||
| pythonConfig, pythonConfig.pyodidePackageManager, {}, release, network, timer); | ||
|
Comment on lines
+5839
to
+5840
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seemed like it, I started getting errors about missing crypto when I removed it.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment? |
||
| } | ||
| } | ||
| } | ||
|
|
||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.