Fix Rust Chat App Tutorial not showing messages of other users live#4588
Open
OMGeeky wants to merge 2 commits intoclockworklabs:masterfrom
Open
Fix Rust Chat App Tutorial not showing messages of other users live#4588OMGeeky wants to merge 2 commits intoclockworklabs:masterfrom
OMGeeky wants to merge 2 commits intoclockworklabs:masterfrom
Conversation
Signed-off-by: Frederik <39029799+OMGeeky@users.noreply.github.com>
|
|
Signed-off-by: Frederik <39029799+OMGeeky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes an Issue in the Rust Chat App Tutorial, that is caused by the Event Type Changes in 2.0
This resulted in other clients not receiving new messages, since they are now Event::Transaction and no longer included within the Event::Reducer
API and ABI breaking changes
I don't think any? I only changed a tutorial, the real change was in 2.0
Expected complexity level and risk
1
Testing
There might be more places where this is an Issue, I just noticed this one while following the Tutorial.