Skip to content

Fix useTable isReady reverting to false after first row event #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clockwork-labs-bot wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

Fix useTable isReady reverting to false after first row event #4580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/bindings-typescript/src/react/useTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ export function useTable<TableDef extends UntypedTableDef>(
connectionState,
accessorName,
querySql,
computeSnapshot,
Copy link
Collaborator

@bfops bfops Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice we explicitly disable the lint to check that the dependency array is exhaustive, so I'm a little wary of making innocuous-looking changes. I'm not sure who put that there (or if it was AI).

callbacks?.onDelete,
callbacks?.onInsert,
callbacks?.onUpdate,
Expand Down
Loading