-
Notifications
You must be signed in to change notification settings - Fork 431
feat(ui): enforce minimum clerk-js version compatibility #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bratsos
wants to merge
1
commit into
main
Choose a base branch
from
alexbratsos/user-4102-implement-minimum-clerkjs-sdk-version-in-clerkui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| import { ClerkRuntimeError } from '@clerk/shared/error'; | ||
| import { logger } from '@clerk/shared/logger'; | ||
| import type { ModuleManager } from '@clerk/shared/moduleManager'; | ||
| import type { Clerk, ClerkOptions, EnvironmentResource } from '@clerk/shared/types'; | ||
| import type { ClerkUiInstance, ComponentControls as SharedComponentControls } from '@clerk/shared/ui'; | ||
| import { isVersionAtLeast, parseVersion } from '@clerk/shared/versionCheck'; | ||
|
|
||
| import { type MountComponentRenderer, mountComponentRenderer } from './Components'; | ||
| import { MIN_CLERK_JS_VERSION } from './constants'; | ||
|
|
||
| export class ClerkUi implements ClerkUiInstance { | ||
| static version = __PKG_VERSION__; | ||
|
|
@@ -16,6 +20,33 @@ export class ClerkUi implements ClerkUiInstance { | |
| options: ClerkOptions, | ||
| moduleManager: ModuleManager, | ||
| ) { | ||
| const clerk = getClerk(); | ||
| const clerkVersion = clerk?.version; | ||
| const isDevelopmentInstance = clerk?.instanceType === 'development'; | ||
| const parsedVersion = parseVersion(clerkVersion ?? ''); | ||
|
|
||
| let incompatibilityMessage: string | null = null; | ||
|
|
||
| if (parsedVersion && !isVersionAtLeast(clerkVersion, MIN_CLERK_JS_VERSION)) { | ||
| incompatibilityMessage = | ||
| `@clerk/ui@${ClerkUi.version} requires @clerk/clerk-js@>=${MIN_CLERK_JS_VERSION}, ` + | ||
| `but found @clerk/clerk-js@${clerkVersion}. ` + | ||
| `Please upgrade @clerk/clerk-js (or your framework SDK) to a compatible version.`; | ||
| } else if (!parsedVersion && !moduleManager) { | ||
| incompatibilityMessage = | ||
| `@clerk/ui@${ClerkUi.version} requires @clerk/clerk-js@>=${MIN_CLERK_JS_VERSION}, ` + | ||
| `but found an incompatible version${clerkVersion ? ` (${clerkVersion})` : ''}. ` + | ||
| `Please upgrade @clerk/clerk-js (or your framework SDK) to a compatible version.`; | ||
| } | ||
|
|
||
| if (incompatibilityMessage) { | ||
| if (isDevelopmentInstance) { | ||
| logger.warnOnce(incompatibilityMessage); | ||
| } else { | ||
| throw new ClerkRuntimeError(incompatibilityMessage, { code: 'clerk_ui_version_mismatch' }); | ||
| } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be the other way around? Typically we want to fail fast in development (so devs catch issues early) but be more lenient in production (to avoid breaking user-facing apps). The current behavior warns in dev (easy to miss) but throws in prod (could cause outages). |
||
| } | ||
|
|
||
| this.#componentRenderer = mountComponentRenderer(getClerk, getEnvironment, options, moduleManager); | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at clerk-js, it always instantiates ClerkUi with
new ModuleManager(), andclerkVersioncomes from the Clerk instance which should always have its version set. Is there a scenario where ClerkUi would be instantiated without a moduleManager or without knowing the clerkVersion? If this is just defensive coding thats fine, but if theres an actual use case Im curious what it is :)