-
Notifications
You must be signed in to change notification settings - Fork 431
feat(clerk-js): Include current search params in handleRedirectCallback
#7600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/core-2
Are you sure you want to change the base?
feat(clerk-js): Include current search params in handleRedirectCallback
#7600
Conversation
…ack` so that component `AuthenticateWithRedirectCallback` automatically incorporates any redirects in the current query to match the documented usage https://clerk.com/docs/guides/development/custom-flows/authentication/oauth-connections
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
handleRedirectCallbackhandleRedirectCallback
…ails-for-new-users-custom-sso
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
so that component
AuthenticateWithRedirectCallbackautomatically incorporates any redirects in the current query to match the documented usagePart of USER-4308
Without a fix like this the developer must manually snag and specify all the possible redirects, which I think is not the intent of the component.
Note to Reviewers
❓ Is this the best place to insert the URL's query params? It could be done at a higher level, e.g. adding an argument to
handleRedirectCallback. Are there scenarios where it is undesirable to automatically use the window's current query?❓ What are some scenarios I should manually test?
It would be helpful to consider this change in conjunction with this docs change. I acknowledge that the change to the docs is not ideal; it makes the code example much longer. But, my thinking is to first: make it correct, second: make SDK improvements that could reduce the burden on customers.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change