This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Extract-to-lib rdebug options parsing, add tests#108
Open
eric-hu wants to merge 9 commits intocldwalker:masterfrom
Open
Extract-to-lib rdebug options parsing, add tests#108eric-hu wants to merge 9 commits intocldwalker:masterfrom
eric-hu wants to merge 9 commits intocldwalker:masterfrom
Conversation
Add setup instructions for first time contributors.
A passing test file was previously being neglected
With pair programming help from @natecraft1 Change parser variable names to be more descriptive
Fix file path references.
Owner
|
Thanks for reporting your issue! This is one of my 24 active issues. Use that link to check how soon your issue will be answered. Don't forget to check your issue against this project's CONTRIBUTING.md. Cheers. |
|
@eric-hu did a good job here, and the tests are passing for ruby 1.9.3 Could you get this merged, @cldwalker? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for issue [#57]. I took the feedback from deivid-rodriguez to rewrite some tests and squashed out some of my old commits.