Skip to content

Revert "feat: 添加 /goal 命令,支持长时间运行任务的目标管理"#1236

Merged
claude-code-best merged 1 commit into
mainfrom
revert-1222-feat/goal-command
May 17, 2026
Merged

Revert "feat: 添加 /goal 命令,支持长时间运行任务的目标管理"#1236
claude-code-best merged 1 commit into
mainfrom
revert-1222-feat/goal-command

Conversation

@claude-code-best
Copy link
Copy Markdown
Owner

@claude-code-best claude-code-best commented May 17, 2026

Reverts #1222

Summary by CodeRabbit

  • Removed Features
    • Removed goal tracking and management functionality, including goal commands, session-based state storage, and goal-related AI tool integration.
    • Removed goal continuation prompts that were previously integrated into system instructions for model interactions.

Review Change Stack

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 17, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
ccb-863780bf 🟢 Ready View Preview May 17, 2026, 2:06 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude-code-best claude-code-best merged commit 2cc9a7d into main May 17, 2026
6 of 7 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e8ffb6ef-0f3b-4bcf-a417-5c8cbf7f75df

📥 Commits

Reviewing files that changed from the base of the PR and between d66a6f6 and 9bd8622.

📒 Files selected for processing (10)
  • packages/builtin-tools/src/index.ts
  • packages/builtin-tools/src/tools/GoalTool/GoalTool.ts
  • packages/builtin-tools/src/tools/GoalTool/prompt.ts
  • src/commands.ts
  • src/commands/goal/goal.ts
  • src/commands/goal/index.ts
  • src/constants/prompts.ts
  • src/query.ts
  • src/services/goal/goalState.ts
  • src/tools.ts

📝 Walkthrough

Walkthrough

This PR removes the entire goal-tracking feature from the codebase, including the GoalTool from the builtin tool registry, the goal CLI command handler, the goal state service, and all integrations that tracked goal progress and injected goal state into system prompts and token usage calculations.

Changes

Goal Feature Removal

Layer / File(s) Summary
Builtin Tool Registry Cleanup
packages/builtin-tools/src/index.ts, packages/builtin-tools/src/tools/GoalTool/GoalTool.ts, src/tools.ts
The 120-line GoalTool implementation (with Zod schemas, get/set/complete action handlers, and result rendering) is deleted. Removed from both the barrel export and the getAllBaseTools() return array.
CLI Command Deregistration
src/commands.ts
The goal command module import and its entry in the memoized COMMANDS array are removed from the command registry.
Query and Prompt Integration Cleanup
src/query.ts, src/constants/prompts.ts
Token tracking: removed updateGoalTokens import and the post-model "Update goal token usage" computation. Prompt generation: removed getGoalContinuationPrompt import and the goal_continuation uncached system prompt section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A goal once tracked through every turn,
Now fades away—one less concern,
The tool, the command, the state so neat,
All swept away, no longer complete!
wiggles nose

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-1222-feat/goal-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants