Refactor crypto_boringssl to use return types internally#78
Open
k-wasniowski wants to merge 5 commits intocisco:mainfrom
Open
Refactor crypto_boringssl to use return types internally#78k-wasniowski wants to merge 5 commits intocisco:mainfrom
k-wasniowski wants to merge 5 commits intocisco:mainfrom
Conversation
bifurcation
approved these changes
Mar 6, 2026
| hkdf_extract(CipherSuite suite, input_bytes salt, input_bytes ikm) | ||
| { | ||
| const auto* md = openssl_digest_type(suite); | ||
| const auto* md = SFRAME_VALUE_OR_THROW(openssl_digest_type(suite)); |
Contributor
There was a problem hiding this comment.
As with the other PRs, this should be _OR_RETURN.
k-wasniowski
force-pushed
the
refactor-internal-boringssl
branch
from
3fa6b57 to
1e6df50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.