Add Thrift support to build system and CI#41
Closed
Copilot wants to merge 2 commits intothrift_singlefrom
Closed
Conversation
Open
Copilot
AI
changed the title
[WIP] Fix Thrift single issue with performance effects
Add Thrift support to build system and CI
Oct 29, 2025
chenBright
force-pushed
the
thrift_single
branch
3 times, most recently
from
2bc2f4e to
509b558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates Apache Thrift 0.11.0 into the build infrastructure to enable Thrift protocol support in brpc.
Changes
/usrfor unified dependency managementconfig_brpc.shto detect Thrift binary and libraries when--with-thriftis enabledtest/Makefileto compile Thrift-generated sources fromecho.thrift, producinggen-cpp/directory/usrto simplify header/lib path managementBuild system integration
The Thrift compiler generates C++ sources at build time:
Generated files are automatically included in test builds and excluded via
.gitignore.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.