Conversation
Add the git commit hash to the manifest of each platform image.
Clone the entire history when building containers. That way, we will be able to find an appropriate commit hash and time for the containers subdirectory.
Migrate the local container builder to buildah instead of podman. This will permit us to use the `redhat-actions/buildah-build` GH action, or podman directly, to obtain equivalent results on CI.
In buildah and podman, executing a Dockerfile `COPY` operation respects the *host* user's umask. This causes unwanted variation between build environments. Instead, mount the host filesystem and copy the file with the permissions we want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc reproducibility fixes for CI container images:
COPYinstructions, which depend on the host umask