Skip to content

protocol: allow larger SmartContract tx data payloads #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheNewAutonomy merged 1 commit into from
Mar 1, 2026
Merged

protocol: allow larger SmartContract tx data payloads #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions crates/catalyst-core/src/protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ pub const MAX_TX_WIRE_BYTES: usize = 64 * 1024; // 64 KiB (hex decoded, includin
pub const MAX_TX_SIGNATURE_BYTES: usize = 8 * 1024; // room for PQ sigs later
pub const MAX_TX_SENDER_PUBKEY_BYTES: usize = 4 * 1024; // room for PQ pubkeys later

// Bound `TransactionCore.data` separately for clearer errors.
//
// - Most tx types should not carry large blobs in `data` (keep small to reduce DoS surface).
// - SmartContract txs must carry EVM deploy bytecode / calldata, so allow a larger (still bounded)
// payload that fits comfortably within `MAX_TX_WIRE_BYTES`.
pub const MAX_TX_DATA_BYTES_SMALL: usize = 60;
pub const MAX_TX_DATA_BYTES_SMART_CONTRACT: usize = 48 * 1024;

/// Signature scheme id (forward-compatible).
///
/// For now, only Schnorr is accepted by consensus/RPC.
Expand Down Expand Up @@ -510,8 +518,16 @@ impl Transaction {
if self.core.nonce == 0 {
return Err("Transaction nonce must be > 0".to_string());
}
if self.core.data.len() > 60 {
return Err("Transaction data field must be <= 60 bytes".to_string());
let max_data = match self.core.tx_type {
TransactionType::SmartContract => MAX_TX_DATA_BYTES_SMART_CONTRACT,
_ => MAX_TX_DATA_BYTES_SMALL,
};
if self.core.data.len() > max_data {
return Err(format!(
"Transaction data field must be <= {} bytes (got={})",
max_data,
self.core.data.len()
));
}
// Generic safety caps (anti-DoS). Scheme-specific validation belongs in `catalyst-crypto::txauth`.
if self.signature.0.is_empty() {
Expand Down