Adding undefined/null check for container.lat scenarios.#48
Adding undefined/null check for container.lat scenarios.#48caseycesari merged 3 commits intocaseycesari:masterfrom
container.lat scenarios.#48Conversation
|
@caseycesari Any thoughts on taking a look at this? 631ef53 should be straightforward enough. f9e7f50 isn't really necessary, it's just a quick fix for the jshint task. |
|
@hparkertt Hey, thanks for the reminder, and the fix. Any chance you could add a test? If not, I can add one this week and get this released. Thanks. |
|
@caseycesari The tests are in, but I noticed a limitation of GeoJSON that I might try and fix right off. The limitation is that you cannot specify multiple geometry mappings in the param object that do not have similar nested property paths. The buildGeom function returns false at line 234 and at line 252, not allowing the params.geom loop to continue and attempt to find a matching nested property path with a different geometry type. EDIT: See #49 |
|
Hi @caseycesari I've added a few issues that can be labeled as 'enhancements'. I probably could have done it a little cleaner, but I've created pull requests for each issue. Overall, here is what I've done:
At this point we should focus discussion for each issue in it's own page; I only listed this out here because this is where our conversation started. This library is a really great, simple tool, and I hope these changes help give it a little extra functionality! Thanks! |
|
@hparkertt Oh wow! Thanks for all of these PRs. I'm going to try and get through these over the next couple days. |
|
This looks good. Merging. |
Resolves #47