Advancer and machine manager reliability improvements

[vfusco]

No description provided.

[Copilot]

Pull request overview

This PR improves reliability across the machine runtime, machine manager, and advancer by tightening error handling, adding bounded batching to avoid large in-memory backlogs, and making shutdown/cleanup more robust.

Changes:

• Introduces a structured AdvanceResponse return type for machine advances and adds a reports-per-input limit with a corresponding completion status.
• Adds batched input replay/synchronization for machine instances and surfaces a configurable ADVANCER_INPUT_BATCH_SIZE.
• Improves advancer and manager shutdown semantics (graceful HTTP shutdown, closing machine instances to avoid orphan processes) and snapshot handling safety.

Reviewed changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/machine/machine.go	Adds AdvanceResponse; wraps cancel/deadline errors; introduces ErrReportsLimitExceeded; updates Machine.Advance signature.
pkg/machine/implementation.go	Enforces report limits; replaces panics with errors; adds context checks in run loop; updates advance return shape.
pkg/machine/machine_test.go	Updates tests for new AdvanceResponse API and adds load-path error coverage.
pkg/machine/implementation_test.go	Adds coverage for outputs hash proof/checkpoint write and additional run-loop behaviors; updates advance tests to new API.
pkg/machine/libcartesi.go	Removes stray println on JSON unmarshal failure.
internal/manager/types.go	Extends interfaces: Synchronize now takes batchSize, OutputsProof signature change, and adds MachineProvider.Close.
internal/manager/manager.go	Adds instance factory abstraction; adds close semantics; switches synchronization to batched replay; improves snapshot fallback logic.
internal/manager/instance.go	Implements batched Synchronize; hardens runtime lifecycle with destroy-on-unrecoverable-error; adds close timeout draining inspects; atomic processed input tracking.
internal/manager/manager_test.go	Updates tests for new manager ctor/options and adds new error-path + Close aggregation tests.
internal/manager/instance_test.go	Adds extensive coverage for snapshot init, outputs proof/hash behaviors, synchronize batching, and close-timeout behavior.
internal/manager/pmutex/pmutex_test.go	Reworks contested lock tests to avoid testify’s Never helper and to ensure cleanup/unblock.
internal/advancer/service.go	Adds graceful HTTP server shutdown and machine manager close on Stop; propagates server failure via cancellation; wires batch size into manager creation.
internal/advancer/advancer.go	Fetches/processes inputs in batches; triggers shutdown on store-after-advance failure; improves snapshot path join + deletion safety checks.
internal/advancer/advancer_test.go	Refactors test setup; adds broad coverage for batching, epoch handling, snapshot lifecycle, and shutdown-triggering scenarios.
internal/config/generated.go	Adds CARTESI_ADVANCER_INPUT_BATCH_SIZE config with defaults and loaders for advancer/node.
internal/config/generate/Config.toml	Adds config generator entry for CARTESI_ADVANCER_INPUT_BATCH_SIZE.
internal/repository/postgres/schema/migrations/000001_create_initial_schema.up.sql	Extends InputCompletionStatus enum with REPORTS_LIMIT_EXCEEDED.
internal/repository/postgres/db/rollupsdb/public/enum/inputcompletionstatus.go	Updates generated enum mapping for REPORTS_LIMIT_EXCEEDED.
internal/model/models.go	Adds model enum value + scan handling for REPORTS_LIMIT_EXCEEDED.
internal/repository/postgres/repository_error_test.go	Minor formatting alignment change.
internal/inspect/inspect_test.go	Updates mock interface signatures for Synchronize/OutputsProof.
cmd/cartesi-rollups-cli/root/read/read.go	Minor formatting fix for flag setting.
Makefile	Exposes MACOSX_DEPLOYMENT_TARGET in make env output when set.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[mpolitzer]

added a few comments, mostly nitpicks