fix(terminal): configure ImageAddon with memory-safe defaults#4367
Merged
gregpriday merged 2 commits intodevelopfrom Mar 28, 2026
Merged
fix(terminal): configure ImageAddon with memory-safe defaults#4367gregpriday merged 2 commits intodevelopfrom
gregpriday merged 2 commits intodevelopfrom
Conversation
- Add IMAGE_ADDON_OPTIONS constant with pixelLimit: 2_000_000 and storageLimit: 8 - Apply to both setupTerminalAddons and createImageAddon callsites - Add unit tests asserting constructor receives memory-safe options
- Run prettier on TerminalAddonManager.test.ts
gregpriday
force-pushed
the
feature/issue-4363-configure-imageaddon-memory
branch
from
c516be6 to
24020fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageAddonwas being instantiated with barenew ImageAddon()at both the initial setup and unhibernate callsites, leaving the defaults at 128 MB storage and 16M pixel limit per terminalpixelLimit: 2_000_000andstorageLimit: 8(MB), capping per-terminal image cache at 8 MBResolves #4363
Changes
src/services/terminal/TerminalAddonManager.ts— pass memory-safe options toImageAddoninsetupTerminalAddonsandcreateImageAddonsrc/services/terminal/__tests__/TerminalAddonManager.test.ts— new test file verifying addon configurationTesting
Unit tests added and passing. The fix applies to both terminal creation and post-hibernation restore paths.