This repository was archived by the owner on Aug 16, 2023. It is now read-only.
Open
Conversation
Conflicts: SimpleAuth.xcodeproj/project.pbxproj
Conflicts: SimpleAuth.xcodeproj/project.pbxproj
Owner
|
Thanks for the contribution, sorry it took me so long to get to it. I can't stand the Facebook SDK and I think I'll rebuild this manually so we don't have to rely on that. I'll get to it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
Here is an implementation of Facebook SSO.
It has the same requirements as Facebook SDK, which are:
- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url sourceApplication:(NSString *)sourceApplication annotation:(id)annotation { return [SimpleAuth handleCallback:url]; }It should handle most cases, but still needs to be heavily tested.
We decided that the FBSession should be closed after each opening, so the provider will fetch a new token each time it is called.
Facebook's errors are handled and passed as underlying errors, and it is left to the developer's choice to specifically handle them.
We think that it is as simple as it can be for the developer, and that you will like it. :)
I updated the podspec to include Facebook iOS SDK, but you should review it as I'm no pro with .podspec…
Julien