⚡ Bolt: Prevent task serialization in concurrent scanners#46
⚡ Bolt: Prevent task serialization in concurrent scanners#46
Conversation
…ation Converting CacheScanner and NodeModulesScanner from `actor` to `struct` since they are stateless. Using an actor with `withTaskGroup` inadvertently serializes all child tasks onto the actor's single-threaded executor, destroying parallelism. This change allows true parallel filesystem traversal. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Converted
CacheScannerandNodeModulesScannerfromactortostruct.🎯 Why: In Swift structured concurrency, launching a
withTaskGroupfrom inside anactorcauses all child tasks to run sequentially on the actor's executor, destroying intended parallelism for filesystem scanning. Since these scanner types are entirely stateless, they don't need actor isolation.📊 Impact: Significant reduction in scan time (especially for recursive node_modules searches across multiple roots) by allowing true parallel disk I/O on available CPU threads.
🔬 Measurement: Run the app and observe the completion time of a full scan. Time will be significantly shorter on systems with deep/complex Node project directories.
PR created automatically by Jules for task 14855552840901043264 started by @acebytes