Conversation
- Wrapped CategoryRow and NodeModulesRow in Buttons - Added .contentShape(Rectangle()) to make empty space clickable - Added .buttonStyle(.plain) to prevent visual changes - Added .accessibilityElement(children: .combine) for better VoiceOver experience Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Wrapped
CategoryRowandNodeModulesRowlist entries entirely inButtonstructures instead of just having clickable checkboxes.🎯 Why
Previously, only the small checkbox icon was clickable. By default, SwiftUI
HStackdoes not expand a button's hit area to the full row. This fix applies Fitts's Law to massively increase the clickable hit target to the entire row, making selection much easier.📸 Before/After
Before: Clicking anywhere on the text, icons, or empty space of a row did nothing. You had to precisely click the checkbox. VoiceOver read each element (icon, text, badge, size) separately.
After: Clicking anywhere on the row toggles the selection.
♿ Accessibility
Added
.accessibilityElement(children: .combine). Previously, VoiceOver users had to swipe through 4-5 different elements per row (Checkbox, Icon, Title, Badge, Size). Now, the entire row is treated as a single, cohesive interactive element, dramatically speeding up screen reader navigation.PR created automatically by Jules for task 11384765283590562748 started by @acebytes