⚡ Bolt: [performance improvement] Offload blocking I/O off the @MainActor#41
⚡ Bolt: [performance improvement] Offload blocking I/O off the @MainActor#41
Conversation
- Wrapped `DiskInfo.current()`, `Process` execution, `waitUntilExit()`, and `Pipe` reads inside `Task.detached { ... }` in `CacheoutViewModel`.
- This ensures these synchronous blocking I/O calls run on the background concurrent pool rather than blocking the main UI thread.
- Results are safely awaited and assigned back to the `@MainActor` variables (`diskInfo` and `lastDockerPruneResult`).
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Refactored
CacheoutViewModelto offload synchronous, blocking operations likeDiskInfo.current(),Processexecution,waitUntilExit(), andreadDataToEndOfFile()off the@MainActorby usingTask.detached { ... }.value.🎯 Why: Executing these I/O-heavy blocking operations on the
@MainActorblocked the main thread. This causes UI hitching or unresponsiveness while waiting for file system attributes to be read or external shell processes (likedocker system prune) to exit.📊 Impact: Greatly improves UI responsiveness by preventing the main thread from stalling. Heavy synchronous I/O operations are correctly dispatched to the background concurrent pool.
🔬 Measurement: Verify that the main UI remains perfectly responsive and smooth while running the scan process or running "Docker prune" from the menubar, especially when the file system is slow or the
docker pruneprocess takes seconds to finish.PR created automatically by Jules for task 4555539010936744612 started by @acebytes