🎨 Palette: Expand list row hit targets and improve VoiceOver accessibility#38
🎨 Palette: Expand list row hit targets and improve VoiceOver accessibility#38
Conversation
…ility Wrapped the entire `HStack` in `CategoryRow` and `NodeModulesRow` within `Button` components and applied `.contentShape(Rectangle())` to make the empty spaces clickable. Additionally, `.accessibilityElement(children: .combine)` was added to both to group the row's child elements for a better VoiceOver experience. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Expanded the clickable area of list rows (
CategoryRowandNodeModulesRow) to encompass the entire row, not just the small selection checkbox. Also combined accessibility elements within each row.🎯 Why: In the previous implementation, users had to click exactly on the small circle/checkbox to toggle selections, which is a very small hit target. Wrapping the entire row and making empty space clickable drastically improves usability, especially for trackpad or potential touch users.
📸 Before/After: Visually, the UI remains identical as
.buttonStyle(.plain)suppresses default button styling, but the hit target now covers the full row.♿ Accessibility:
.accessibilityElement(children: .combine)so VoiceOver reads the entire row context (name, description, size, status) together as one coherent item instead of requiring users to navigate through fragmented individual text elements.PR created automatically by Jules for task 14402447652450443943 started by @acebytes