Skip to content

🎨 Palette: Make list rows fully clickable with better VoiceOver support#32

Open
acebytes wants to merge 1 commit intomainfrom
palette/swiftui-list-row-a11y-17121227047300471241
Open

🎨 Palette: Make list rows fully clickable with better VoiceOver support#32
acebytes wants to merge 1 commit intomainfrom
palette/swiftui-list-row-a11y-17121227047300471241

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Expanded the clickable hit target of list rows (CategoryRow and NodeModulesRow) to encompass the entire width of the row rather than just the selection checkbox, and unified their VoiceOver announcements.
🎯 Why: Users had to precisely tap a small circular checkbox to select an item. By wrapping the entire row in a Button with a rectangular content shape, the interaction feels significantly smoother and native.
📸 Before/After: Visually identical, interaction area expanded from ~24x24pt to full row width.
Accessibility: Added .accessibilityElement(children: .combine) and tied .accessibilityAddTraits(.isSelected) to the check state so that screen readers correctly announce the entire row's context and its current toggle status as a single interactive element, preventing fragmented navigation.

Also added a critical learning to .jules/palette.md detailing this SwiftUI-specific behavior.


PR created automatically by Jules for task 17121227047300471241 started by @acebytes

Wrapped the entire `HStack` contents in `CategoryRow.swift` and `NodeModulesSection.swift` in a `Button` to expand hit targets to the entire row edge-to-edge. Added `contentShape(Rectangle())` for empty space interactivity and `.accessibilityElement(children: .combine)` to consolidate the row VoiceOver readout.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant