Skip to content

CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std tagets#12812

Open
the-ssd wants to merge 3 commits intobytecodealliance:mainfrom
the-ssd:main
Open

CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std tagets#12812
the-ssd wants to merge 3 commits intobytecodealliance:mainfrom
the-ssd:main

Conversation

@the-ssd
Copy link
Contributor

@the-ssd the-ssd commented Mar 20, 2026

This PR add a check in CI so that there aren't any regressions in the future.
Closes #1158. This was possible after #12596.

the-ssd added 2 commits March 20, 2026 22:19
CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std targets
@the-ssd the-ssd requested a review from a team as a code owner March 20, 2026 21:26
@the-ssd the-ssd requested review from rvolosatovs and removed request for a team March 20, 2026 21:26
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cargo check -p wasmtime --no-default-features --features runtime,gc,component-model,pulley,async,debug,debug-builtins,demangle,anyhow &&
cargo check -p cranelift-control --no-default-features &&
cargo check -p cranelift-assembler-x64 --lib &&
cargo check -p cranelift-codegen --no-default-features -F x86,arm64 &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with all the other checks, could you spell the flag --features rather than -F?

@alexcrichton alexcrichton added this pull request to the merge queue Mar 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cranelift-codegen no longer builds with no_std

3 participants