Make the postgres database persistent in the simple example#26
Open
hollie wants to merge 1 commit intobuildbot:masterfrom
Open
Make the postgres database persistent in the simple example#26hollie wants to merge 1 commit intobuildbot:masterfrom
hollie wants to merge 1 commit intobuildbot:masterfrom
Conversation
By default the database container in the simple example is not persistent, when recreating the db container the data is the existing container is erased. With this change the database contant is stored in a docker container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the content of the database container in the simple example is not persistent. When recreating the db container the data in the existing container is erased and you start again with an empty database.
With this change the database content is stored in a docker volume so that the content is retained over rebuilds of the database container.
I propose to make this change because if people start from the simple example and extend it, they should not forget to make the information in the database container persistent.
I might or might not have encountered this myself while setting up buildbot 😉