Merged
Conversation
`protobuf` v7 was released last week, which dropped support for some of the APIs that we use for checking field types. This fixes those accesses so that we can still support all the way back to v5. Fixes #410. Ref: https://pypi.org/project/protobuf/ Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0
stefanvanburen
force-pushed
the
svanburen/protobuf-7
branch
from
95deafd to
415d038
Compare
Contributor
|
Do we actually want to keep supporting v5? According to the documentation, it is maintenance-only (https://protobuf.dev/support/version-support) and support will end at the end of the month (https://protobuf.dev/support/version-support/#python) |
Member
Author
|
@AdrienVannson good question — for now, I think we ought to leave around support since it's trivial on our end. Last time I looked, a lot of OSS libraries and users were still using I'd like to release this, and then maybe we can drop support for the next release? |
Contributor
|
I see. Apart from this, this looks good |
AdrienVannson
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobufv7 was released last week, which dropped support for some of the APIs that we use for checking field types. This fixes those accesses so that we can still support all the way back to v5.Fixes #410.
Ref: https://pypi.org/project/protobuf/
Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0